Conversation
JohanMabille
approved these changes
Jan 14, 2026
ianthomas23
requested changes
Jan 14, 2026
src/subcommand/config_subcommand.cpp
Outdated
| { | ||
| if (m_name.empty()) | ||
| { | ||
| std::cout << "error: wrong number of arguments, should be 1" << std::endl; |
Member
There was a problem hiding this comment.
Shouldn't this raise an exception rather than just write to cout, so that git2cpp exits with a non-zero exit code? git gives an exit code of 129.
src/subcommand/config_subcommand.cpp
Outdated
| { | ||
| if (m_name.empty() | m_value.empty()) | ||
| { | ||
| std::cout << "error: wrong number of arguments, should be 2" << std::endl; |
src/subcommand/config_subcommand.cpp
Outdated
| { | ||
| if (m_name.empty()) | ||
| { | ||
| std::cout << "error: wrong number of arguments, should be 1" << std::endl; |
test/test_config.py
Outdated
| import pytest | ||
|
|
||
|
|
||
| def test_config_list(commit_env_config, git2cpp_path, tmp_path, monkeypatch): |
Member
There was a problem hiding this comment.
We don't actually need the monkeypatch to be specified here, it will be used anyway. Probably we've done the same in lots of other places, I guess it can be future work to go through and remove the unwanted ones or perhaps a python linter will do this for us eventually.
test/test_config.py
Outdated
| cmd_get = [git2cpp_path, "config", "get", "core.bare"] | ||
| p_get = subprocess.run(cmd_get, capture_output=True, cwd=tmp_path, text=True) | ||
| assert p_get.returncode == 0 | ||
| print(p_get.stdout) |
Member
There was a problem hiding this comment.
Debug print can be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
git configsub-command.git config listgit config setgit config getgit config unset